Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: 0 appearing on sidebar on specific occasions #28056

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Regression: 0 appearing on sidebar on specific occasions #28056

merged 1 commit into from
Feb 16, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Feb 15, 2023 •
edited
Loading

Proposed changes (including videos or screenshots)

Fixed faulty logic

Issue(s)

Steps to test or reproduce

  • Create a room
  • Go to notification preferences in that room
  • Disable "Mark as Unread"
  • Enable "Show badge for mentions"

A 0 will appear when there's no unread messages.

Further comments

TC-475

@gabriellsh gabriellsh requested a review from a team as a code owner February 15, 2023 20:22
@tassoevan tassoevan added this to the 6.0.0 milestone Feb 15, 2023
@ggazzo ggazzo merged commit 33eb522 into develop Feb 16, 2023
@ggazzo ggazzo deleted the fix/0 branch February 16, 2023 03:16
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Merged
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

@ggazzo ggazzo ggazzo approved these changes

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gabriellsh @tassoevan @ggazzo @MartinSchoeler